Update markdown_controller.js#939
Merged
jbtronics merged 1 commit intoPart-DB:masterfrom Sep 6, 2025
Merged
Conversation
Don't handle links as external by default. Instead distiguish internal (relative) and external (absolute) links.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #939 +/- ##
============================================
- Coverage 59.73% 59.71% -0.02%
Complexity 6036 6036
============================================
Files 529 529
Lines 20588 20588
============================================
- Hits 12298 12295 -3
- Misses 8290 8293 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
An internal path can be absolute too, but I see no disadvantage in having this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't handle links as external by default. Instead distiguish internal (relative) and external (absolute) links.
That way, if you link to filters in your Part-DB banner, you won't end up with lots of tabs open at the end of the day.